On Mon, 2009-03-09 at 19:38 +0100, Matthias Urlichs wrote: > Hi, > > oliver@xxxxxxxxxx: > > It seems to me most of this belongs into the generic layer. > > I agree. > > > Also, using strings here really is arcane, as this will be parsed by > > software. > > > Both numbers and strings are magic, and the computational difference > between atoi() and strcmp() is negligible. > > One comment about the implementation: Please use a table-driven > approach. We need that for some other enhancements that are planned for > the option driver anyway (for instance: URB sizes need to be adapted to > the device). You mean like adding something to the usb device table driver data pointer? Dan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
