On Fri, Mar 6, 2009 at 8:19 PM, Steve Longerbeam <stevel@xxxxxxxxxxxxxxx> wrote: > Mike Lockwood wrote: > > On Mon, Nov 17, 2008 at 9:19 PM, Steve Longerbeam > <stevel@xxxxxxxxxxxxxxx> wrote: > > > David Brownell wrote: > > On Thursday 06 November 2008, Mike Lockwood wrote: > > > > Has anyone refactored file_storage.c to work within composite driver > yet? I'm happy to do it, but am wondering if I would duplicate > someone else's work. > > > I have a copy in my mailbox that I've been meaning to look at. > One of many large patches. :( > > I've Bcc'd the patch author in case he has any updates ... > > > Hi Dave, > > No updates. I'll be in a position to test the patches soon, ATM they compile > but are untested. > > > Any update on your changes for getting file_storage working as a > composite driver? I would like to get this working in android. I'd > be happy to pick up from where you left off if you don't have time to > work on it. > > > Hi Mike, I have a working f_file_storage now. It took a while for two > reasons: > > First, as you probably know, file storage has to carry out set_alt() and > disable() in a sleep-able thread, because these operations require file I/O > on the backing store. This required some changes to composite.c because the > composite framework handles all setup callbacks from udc driver at interrupt > time. > > Second, I've been having lots of trouble with the OTG controller I'm using > to debug the composite changes for file storage. I wasn't entirely sure the > problems were due to the composite changes or due to the udc > driver/controller, but now I'm fairly convinced it is the latter. If only I > had an Android I would have had a known-good udc driver to debug the file > storage with. > > Anyway, attached are the raw files. I haven't had time yet to give you a > patch against the latest USB git tree, these are running in 2.6.25 with a > back-ported composite gadget stack. So they are of questionable value to you > right now. But here it is in case it's something you can work with. I'm > working on cleaning this up and constructing a patch against latest git. Great! I will try out your f_file_storage as soon as I can get back to working on USB (I have been busy fixing bugs elsewhere in android). It probably won't be too hard to bring this up to the latest kernel. thanks, Mike -- Mike Lockwood Google android team -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
