Re: [PATCH] usb: musb: musb_cppi41: Update an error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/02/2017 07:50 PM, Alexandre Bailon wrote:

If dma_request_slave_channel() failed to return a channel,
then the driver will print an error and request to defer probe.
Update the error message to explain we are defrering probe.

Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
---
  drivers/usb/musb/musb_cppi41.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index e7c8b1b..e6b9161 100644
--- a/drivers/usb/musb/musb_cppi41.c
+++ b/drivers/usb/musb/musb_cppi41.c
@@ -676,6 +676,7 @@ static int cppi41_dma_controller_start(struct
cppi41_dma_controller *controller)
          dc = dma_request_slave_channel(dev->parent, str);
          if (!dc) {
              dev_err(dev, "Failed to request %s.\n", str);
+            dev_info(dev, "Deferring probe.\n");
Please merge the two lines above into one statement, using dev_info().
Well, if I merge the two lines, the patch won't pass checkpatch because the
string is too long.

No, checkpatch.pl shouldn't complain about the strings passed to dev_info() and friends.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux