On 05/01/2017 04:47 PM, Bin Liu wrote:
Hi,
On Fri, Apr 28, 2017 at 06:04:54PM +0200, Alexandre Bailon wrote:
If dma_request_slave_channel() failed to return a channel,
then the driver will print an error and request to defer probe.
Update the error message to explain we are defrering probe.
Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
---
drivers/usb/musb/musb_cppi41.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index e7c8b1b..e6b9161 100644
--- a/drivers/usb/musb/musb_cppi41.c
+++ b/drivers/usb/musb/musb_cppi41.c
@@ -676,6 +676,7 @@ static int cppi41_dma_controller_start(struct cppi41_dma_controller *controller)
dc = dma_request_slave_channel(dev->parent, str);
if (!dc) {
dev_err(dev, "Failed to request %s.\n", str);
+ dev_info(dev, "Deferring probe.\n");
Please merge the two lines above into one statement, using dev_info().
Well, if I merge the two lines, the patch won't pass checkpatch because
the string is too long.
May be should I rephrase to have something shorter.
Regards,
Alexandre
ret = -EPROBE_DEFER;
goto err;
}
Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
