On Friday 20 February 2009, Darius wrote: > From: Darius Augulis <augulis.darius@xxxxxxxxx> > > Fix small bugs and add some omptimization in IMX UDC Gadget. > > Signed-off-by: Darius Augulis <augulis.darius@xxxxxxxxx> Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> ..... this is for 2.6.29-rc right? This part looks a bit dodgey though, in the sense that the support for an empty list should either be fully removed, or left in. The "if (req)" is always going to be true now. > @@ -539,8 +539,7 @@ static int handle_ep0(struct imx_ep_stru > struct imx_request *req = NULL; > int ret = 0; > > - if (!list_empty(&imx_ep->queue)) > - req = list_entry(imx_ep->queue.next, struct imx_request, queue); > + req = list_entry(imx_ep->queue.next, struct imx_request, queue); > if (req) { > switch (imx_ep->imx_usb->ep0state) { -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html