Re: [RFC] usb: gadget: uvc: webcam gadget USB PID is using value from a different gadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 23.1.2017 v 15:27 Felipe Balbi napsal(a):
> 
> Hi,
> 
> Greg KH <greg@xxxxxxxxx> writes:
>>>>> fine by me. Just lsusb will look funky ;-)
>>>>
>>>> Heh, true, but I thought lsusb would use a string if the device provided
>>>> it.  Haven't looked at that portion of the code in a very long time...
>>>>
>>>
>>> My lsusb shows separate strings (using usbutils from slackware64-current):
>>>
>>> Bus 004 Device 003: ID 1d6b:0102 Linux Foundation EEM Gadget
>>> ...
>>>   idVendor           0x1d6b Linux Foundation
>>>   idProduct          0x0102 EEM Gadget
>>>   bcdDevice            4.07
>>>   iManufacturer           1 Linux Foundation
>>>   iProduct                2 Webcam gadget
>>> ...
>>
>> Ah, I guess it doesn't, but who knows how old that version of usbutils
>> is, considering the last release I did was well over a year ago.  I
>> should do a new one one of these days...
>>
>> Anyway, I'd like to not assign a product id to a chunk of code that is
>> going to be eventually deleted.  Felipe, what's the plan for the
>> "legacy" gadget code.  Is it ever going away?
> 
> Well, I wasn't really planning on deleting them just stopped accepting
> any new one. I wanted to avoid angry mobs complaining about not having a
> g_mass_storage.ko anymore.
> 
> Personally, I don't feel strongly about the legacy gadget
> drivers. They're not really needed anymore as everything they do can be
> done with configfs already. Perhaps we could schedule their removal for
> v5.0?
> 

If you want to remove legacy g_webcam then there should be a way to set its module parameters from somewhere (it  seems I can't find it anywhere). For PXA27x especially "opts->streaming_maxpacket" from f_uvc.c is critical. Default max packet size in PXA27x UDC (but lowering the limit to 256 by g_webcam parameter works).

Petr

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux