Re: isp1760-hcd.c driver BUG_ON(!skip_map)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2009-02-17 at 10:16 +0100, Sebastian Andrzej Siewior wrote:
> Catalin Marinas wrote:
> > I get occasional oopses in the enqueue_an_ATL_packet() function because
> > skip_map is empty. This seem to happen when I unplug a USB device,
> > otherwise it works fine. It's a bit strange as skip_map is written in
> > the calling function, do_atl_int().
> > 
> > Any quick thoughts on what may be wrong (with the software or hardware)?
> I'm not real sure what is going on there, a few other people reported this 
> also. They worked around this by adding an udelay(1) before the read of 
> the skip register. That is probably a timming issue but I dunno which one.

It looks like a timing issue. I added a do...while() loop for reading
the skip_map register and it seems to be reliable. Without it it crashes
in 50% of the cases when I unplug the device.

If you are OK with this approach, I'll send a patch later today.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux