Hi Bjørn, 2016-11-21 10:49 GMT+01:00 Bjørn Mork <bjorn@xxxxxxx>: > Daniele Palmas <dnlplm@xxxxxxxxx> writes: > >> it turned out that resetting the interface in cdc_ncm_init after >> getting the NTB parameters removes the need for the sleep, making the >> modem to work fine. > > Sounds very good, although I must admit that it isn't perfectly clear to > me what kind of reset we're talking about here. But no worries, the > patch will make that clear :) > Sorry for the confusion, I meant resetting the MBIM function with RESET_FUNCTION request code. >> I wonder if this is an acceptable solution and can be applied also for MC7455. > > Quite possible. I will definitely test it. If we can avoid an > arbitrary and pointless delay, then that's great. But I guess this also > requires testing with a wide range of other MBIM devices to find out if > we can apply it unconditionally without breaking anything. Avoiding > device-specific or vendor-specific code is important in a class driver, > if possible. > Ok, unfortunately I can test only with Telit modems, so I'm not sure if the change I did is harmless for all the other modems: RESET_FUNCTION should not cause issues, but I also removed altsetting toggling for all MBIM modems and maybe this is not acceptable. Thanks, Daniele > > Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
