Re: [patch] USB: serial: option: add WeTelecom WM-D200

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov wrote:
> USB: serial: option: add WeTelecom WM-D200
> 
> Add support for WeTelecom WM-D200.
> 
> T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  4 Spd=12  MxCh= 0
> D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=22de ProdID=6801 Rev=00.00
> S:  Manufacturer=WeTelecom Incorporated
> S:  Product=WeTelecom Mobile Products
> C:  #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-
> storage

While you're at it, why not add PID 0x6802 and 0x6803?  These are also
listed here:

http://www.mts.ua/upload/files/we/te/wetelecom_windows_drivers.zip

with the same USB layout as the WM-D200.

Dan

> Signed-off-by: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
> ---
> --- a/linux/drivers/usb/serial/option.c	2016-08-20
> 14:44:19.668791103 +0300
> +++ b/linux/drivers/usb/serial/option.c	2016-08-20
> 14:43:24.376790761 +0300
> @@ -525,6 +525,10 @@ static void option_instat_callback(struc
>  #define VIATELECOM_VENDOR_ID			0x15eb
>  #define VIATELECOM_PRODUCT_CDS7			0x0001
>  
> +/* WeTelecom products */
> +#define WETELECOM_VENDOR_ID			0x22de
> +#define WETELECOM_PRODUCT_WMD200			0x6801
> +
>  struct option_blacklist_info {
>  	/* bitmask of interface numbers blacklisted for send_setup
> */
>  	const unsigned long sendsetup;
> @@ -1991,6 +1995,7 @@ static const struct usb_device_id option
>  	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff)
> },                /* OLICARD300 - MT6225 */
>  	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
>  	{ USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7)
> },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
> WETELECOM_PRODUCT_WMD200, 0xff, 0xff, 0xff) },
>  	{ } /* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, option_ids);
> 
> 20.08.2016 13:29, Aleksandr Makarov пишет:
> > 
> > From: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
> > 
> > USB: serial: option: add WeTelecom WM-D200
> > 
> > Add support for WeTelecom WM-D200.
> > 
> > T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  4 Spd=12  MxCh= 0
> > D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=22de ProdID=6801 Rev=00.00
> > S:  Manufacturer=WeTelecom Incorporated
> > S:  Product=WeTelecom Mobile Products
> > C:  #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff
> > Driver=(none)
> > I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff
> > Driver=(none)
> > I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff
> > Driver=(none)
> > I:  If#= 3 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-
> > storage
> > 
> > Signed-off-by: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
> > ---
> > --- drivers/usb/serial/option.c.orig	2016-08-19
> > 15:15:17.173146316 +0300
> > +++ drivers/usb/serial/option.c	2016-08-19
> > 15:16:04.241147738 +0300
> > @@ -519,6 +519,10 @@ static void option_instat_callback(struc
> >  #define VIATELECOM_VENDOR_ID			0x15eb
> >  #define VIATELECOM_PRODUCT_CDS7			0x0001
> >  
> > +/* WeTelecom products */
> > +#define WETELECOM_VENDOR_ID			0x22de
> > +#define WETELECOM_PRODUCT_WMD200			0x6801
> > +
> >  struct option_blacklist_info {
> >  	/* bitmask of interface numbers blacklisted for send_setup
> > */
> >  	const unsigned long sendsetup;
> > @@ -1969,6 +1973,7 @@ static const struct usb_device_id option
> >  	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff)
> > },                /* OLICARD300 - MT6225 */
> >  	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
> >  	{ USB_DEVICE(VIATELECOM_VENDOR_ID,
> > VIATELECOM_PRODUCT_CDS7) },
> > +	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
> > WETELECOM_PRODUCT_WMD200, 0xff, 0xff, 0xff) },
> >  	{ } /* Terminating entry */
> >  };
> >  MODULE_DEVICE_TABLE(usb, option_ids);
> > 
> > 20.08.2016 13:05, Greg KH пишет:
> > > 
> > > On Sat, Aug 20, 2016 at 11:19:37AM +0300, Aleksandr Makarov
> > > wrote:
> > > > 
> > > > From: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
> > > > 
> > > > USB: serial: option: add WeTelecom WM-D200
> > > > 
> > > > Add support for WeTelecom WM-D200.
> > > > 
> > > > T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  4 Spd=12  MxCh=
> > > > 0
> > > > D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > > > P:  Vendor=22de ProdID=6801 Rev=00.00
> > > > S:  Manufacturer=WeTelecom Incorporated
> > > > S:  Product=WeTelecom Mobile Products
> > > > C:  #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=500mA
> > > > I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff
> > > > Driver=(none)
> > > > I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff
> > > > Driver=(none)
> > > > I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff
> > > > Driver=(none)
> > > > I:  If#= 3 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50
> > > > Driver=usb-storage
> > > > 
> > > > Signed-off-by: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx
> > > > >
> > > > ---
> > > > --- linux/drivers/usb/serial/option.c.orig	2016-08-19
> > > > 15:15:17.173146316
> > > > +0300
> > > > +++ linux/drivers/usb/serial/option.c	2016-08-19
> > > > 15:16:04.241147738 +0300
> > > > @@ -519,6 +519,10 @@ static void option_instat_callback(struc
> > > >  #define VIATELECOM_VENDOR_ID			0x15eb
> > > >  #define VIATELECOM_PRODUCT_CDS7			0x0001
> > > > 
> > > > +/* WeTelecom products */
> > > > +#define WETELECOM_VENDOR_ID			0x22de
> > > > +#define WETELECOM_PRODUCT_WMD200			0x6801
> > > > +
> > > >  struct option_blacklist_info {
> > > >  	/* bitmask of interface numbers blacklisted for
> > > > send_setup */
> > > >  	const unsigned long sendsetup;
> > > > @@ -1969,6 +1973,7 @@ static const struct usb_device_id option
> > > >  	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },
> > > > /* OLICARD300 - MT6225 */
> > > >  	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
> > > >  	{ USB_DEVICE(VIATELECOM_VENDOR_ID,
> > > > VIATELECOM_PRODUCT_CDS7) },
> > > > +	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID,
> > > > WETELECOM_PRODUCT_WMD200, 0xff, 0xff, 0xff) },
> > > >  	{ } /* Terminating entry */
> > > >  };
> > > >  MODULE_DEVICE_TABLE(usb, option_ids);
> > > The patch is line-wrapped and can't be applied :(
> > > 
> > > Can you fix that up and resend please?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb"
> in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux