Felipe, Dave,
Can we have the original patch forwarded to Greg at the earliest as so as to enable existing solution work ?
We can in parallel focus on the structural DMA changes which Felipe indicated that he is focusing on.
regards
swami
________________________________________
From: Sergei Shtylyov [sshtylyov@xxxxxxxxxxxxx]
Sent: Saturday, January 24, 2009 5:29 AM
To: David Brownell
Cc: felipe.balbi@xxxxxxxxx; Subbrathnam, Swaminathan; linux-usb@xxxxxxxxxxxxxxx; davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/3] MUSB : Fix for DaVinci CPPI DMA incorrect handling of actual_len field
Hello.
David Brownell wrote:
>>>>> + cppi_ch->channel.actual_len = 0;
>>>>>
>> Wait, Shouldn't that be set by the musb_{host|gadget}.c? It indeed is. But
>> musb_gadget doesn't do it...
>> To be consistent, we should now remove the duplicate setting in
>> mush_host.c as tusb6010_omap.c does set this field itself too.
>>
>
> Actually I'd be all for initializing it in only one place ...
>
> ... but that implies a substantial cleanup of the DMA paths,
>
Some cleanup is coming soon, at least for the host Tx path -- as part
of ISO Tx DMA fix.
> and I'll be content to defer such only-one-place cleanup until
> that happens.
>
> To summarize, musb_hdrc has four basic DMA paths today, the
> cross product of {RX, TX} and {host, gadget}, each of which
> looks more or less like
>
> if (cppi/davinci)
> do this
> else if (omap native/TUSB)
> do that
>
These two seem to be the same in musb_host..Not in musb_gadget though...
> else if (mentor's DMA)
> do something else
>
> Or at least, that's how it worked before the Blackfin updates.
> It shouldn't be that messy.
>
Well, the mess at least allows to earn many patch points. :-)
> - Dave
WBR, Sergei--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
