Re: [PATCH 2/3] MUSB : Fix for DaVinci CPPI DMA incorrect handling of actual_len field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

David Brownell wrote:

Initializes the actual_len field to 0 before every DMA transaction.

Signed-off-by: Swaminathan S <swami.iyer@xxxxxx>

good catch. actual_len was been initialized with some arbitrary value.

applied, thanks

Lost somewhere and not in mainline for 2.6.28 or the 2.6.29 queue...

I'm going to consider that "applied" as an ack, and stick
this in my copy of the list of pending MUSB patches.

Then I'm going to send that list, with a priority sort, so
that Greg doesn't have to scour the list for all thes
long-overdue patches.

- Dave

---
drivers/usb/musb/cppi_dma.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
index c50cc74..f3bd6d9 100644
--- a/drivers/usb/musb/cppi_dma.c
+++ b/drivers/usb/musb/cppi_dma.c
@@ -988,6 +988,7 @@ static int cppi_channel_program(struct dma_channel *ch,
	cppi_ch->offset = 0;
	cppi_ch->maxpacket = maxpacket;
	cppi_ch->buf_len = len;
+	cppi_ch->channel.actual_len = 0;

Wait, Shouldn't that be set by the musb_{host|gadget}.c? It indeed is. But musb_gadget doesn't do it... To be consistent, we should now remove the duplicate setting in mush_host.c as tusb6010_omap.c does set this field itself too.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux