On Friday 23 January 2009, Sergei Shtylyov wrote:
> >>>+ cppi_ch->channel.actual_len = 0;
>
> Wait, Shouldn't that be set by the musb_{host|gadget}.c? It indeed is. But
> musb_gadget doesn't do it...
> To be consistent, we should now remove the duplicate setting in
> mush_host.c as tusb6010_omap.c does set this field itself too.
Actually I'd be all for initializing it in only one place ...
... but that implies a substantial cleanup of the DMA paths,
and I'll be content to defer such only-one-place cleanup until
that happens.
To summarize, musb_hdrc has four basic DMA paths today, the
cross product of {RX, TX} and {host, gadget}, each of which
looks more or less like
if (cppi/davinci)
do this
else if (omap native/TUSB)
do that
else if (mentor's DMA)
do something else
Or at least, that's how it worked before the Blackfin updates.
It shouldn't be that messy.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
