> -----Original Message----- > From: Johan Hovold [mailto:jhovold@xxxxxxxxx] On Behalf Of Johan Hovold > Sent: Sunday, May 01, 2016 10:20 > To: Konstantin Shkolnyy > Cc: Johan Hovold; Valentin Yakovenkov; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [EXT] Re: [PATCH] Add DCD line support to CP210x driver [...] > > > > + wake_up_interruptible(&port- > > > >port.delta_msr_wait); > > > > + spriv->rx_state = CP210X_STATE_IDLE; > > > > + break; > > > > + } > > > > + } > > > > > > Instead of maintaining this state machine (which should not need to be > > > global, or can the events really be split over multiple bulk > > > transfers?), just scan the buffer for the escape character and if found, > > > > Do you know for sure that they can't be split over multiple transfers, > > in today's and future chips? > > We don't need to care about future chips just yet, but you should know > how the current firmware has been implemented, right? Does it really > split escape chars over multiple transfers? I think if the official spec doesn't spell out this behavior, it effectively means s/w can't assume anything. What problem do you see in persisting this state between callbacks, as this code does? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
