On Sat, 2016-02-20 at 14:50 -0800, Greg Kroah-Hartman wrote: > On Sat, Feb 20, 2016 at 11:44:38PM +0100, Vegard Nossum wrote: > > On 02/20/2016 11:22 PM, Greg Kroah-Hartman wrote: > > >On Tue, Feb 16, 2016 at 05:43:32PM +0100, Oliver Neukum wrote: > > >>On Tue, 2016-02-16 at 13:12 +0100, Vegard Nossum wrote: > > >>>The problem is that USB_APPLEDISPLAY has 'select > > >>>BACKLIGHT_LCD_SUPPORT', > > >>>but BACKLIGHT_LCD_SUPPORT has a dependency on HAS_IOMEM: > > >>> > > >>> menu "Graphics support" > > >>> depends on HAS_IOMEM > > >> > > >>It seems to me that this particular dependency is clearly wrong. > > >>Even an S390 can use USB graphics devices. That suggests an > > >>outright reversion of this particular change. > > > > > >Now reverted. > > > > > > > Just to be clear, you're reverting commit > > e25df1205f37c7bff3ab14fdfc8a5249f3c69c82 (which I believe is the commit > > Oliver was referring to) too, right? > > Nope, I reverted this USB one. It is better to have a false unmet dependency than a falsely disabled driver. Looking at this a bit closer, it seems to me that the backlight drivers put the dependency one level to high and it is necessay to check each backlight driver separatly. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
