Re: commit 4b61b4f205eabfc9f863f805858aa5b32deb3de5 - usb: add HAS_IOMEM dependency to USB_APPLEDISPLAY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/20/2016 11:22 PM, Greg Kroah-Hartman wrote:
On Tue, Feb 16, 2016 at 05:43:32PM +0100, Oliver Neukum wrote:
On Tue, 2016-02-16 at 13:12 +0100, Vegard Nossum wrote:
Alright, let's have a look. The warning I was fixing in this patch
was:

      warning: (USB_APPLEDISPLAY) selects BACKLIGHT_LCD_SUPPORT which
has
unmet direct dependencies (HAS_IOMEM)

The problem is that USB_APPLEDISPLAY has 'select
BACKLIGHT_LCD_SUPPORT',
but BACKLIGHT_LCD_SUPPORT has a dependency on HAS_IOMEM:

      menu "Graphics support"
              depends on HAS_IOMEM

It seems to me that this particular dependency is clearly wrong.
Even an S390 can use USB graphics devices. That suggests an
outright reversion of this particular change.

Now reverted.


Just to be clear, you're reverting commit
e25df1205f37c7bff3ab14fdfc8a5249f3c69c82 (which I believe is the commit
Oliver was referring to) too, right?


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux