Re: [PATCHv2 1/2] usb: dwc3: pci: use build-in properties instead of platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> writes:

> On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> writes:
>> > This should allow the core driver to drop handling of
>> > platform data and expect the platform specific details to
>> > always come from properties.
>> >
>> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>> > Cc: Huang Rui <ray.huang@xxxxxxx>
>> > CC: John Youn <John.Youn@xxxxxxxxxxxx>
>> 
>> doesn't compile dude:
>> 
>> make -k -j16 -- drivers/usb/dwc3/
>>   CHK     include/config/kernel.release
>>   CHK     include/generated/uapi/linux/version.h
>>   CHK     include/generated/utsrelease.h
>>   CHK     include/generated/timeconst.h
>>   CHK     include/generated/bounds.h
>>   CHK     include/generated/asm-offsets.h
>>   CALL    scripts/checksyscalls.sh
>>   CC [M]  drivers/usb/dwc3/dwc3-pci.o
>>   CC [M]  drivers/usb/dwc3/dwc3-keystone.o
>>   CC [M]  drivers/usb/dwc3/dwc3-of-simple.o
>> drivers/usb/dwc3/dwc3-pci.c: In function ‘dwc3_pci_add_pset’:
>> drivers/usb/dwc3/dwc3-pci.c:54:9: error: implicit declaration of function ‘platform_device_add_properties’ [-Werror=implicit-function-declaration]
>>   return platform_device_add_properties(dwc3, &pset);
>
> Which kernel are you using? platform_device_add_properties() is
> available from v4.5-rc1 onwards.

v4.5-rc4, could it be you missed a header or the header misses a stub ?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux