Hi,
Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> writes:
> This should allow the core driver to drop handling of
> platform data and expect the platform specific details to
> always come from properties.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Huang Rui <ray.huang@xxxxxxx>
> CC: John Youn <John.Youn@xxxxxxxxxxxx>
doesn't compile dude:
make -k -j16 -- drivers/usb/dwc3/
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CHK include/generated/timeconst.h
CHK include/generated/bounds.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
CC [M] drivers/usb/dwc3/dwc3-pci.o
CC [M] drivers/usb/dwc3/dwc3-keystone.o
CC [M] drivers/usb/dwc3/dwc3-of-simple.o
drivers/usb/dwc3/dwc3-pci.c: In function ‘dwc3_pci_add_pset’:
drivers/usb/dwc3/dwc3-pci.c:54:9: error: implicit declaration of function ‘platform_device_add_properties’ [-Werror=implicit-function-declaration]
return platform_device_add_properties(dwc3, &pset);
^
drivers/usb/dwc3/dwc3-pci.c: In function ‘dwc3_pci_quirks’:
drivers/usb/dwc3/dwc3-pci.c:62:4: error: implicit declaration of function ‘PROPERTY_ENTRY_BOOL’ [-Werror=implicit-function-declaration]
PROPERTY_ENTRY_BOOL("snps,has-lpm-erratum"),
^
drivers/usb/dwc3/dwc3-pci.c:62:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
drivers/usb/dwc3/dwc3-pci.c:62:4: note: (near initialization for ‘pentry[0].name’)
drivers/usb/dwc3/dwc3-pci.c:63:4: error: implicit declaration of function ‘PROPERTY_ENTRY_U8’ [-Werror=implicit-function-declaration]
PROPERTY_ENTRY_U8("snps,lpm-nyet-threshold", 0xf),
^
drivers/usb/dwc3/dwc3-pci.c:65:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,u2ss_inp3_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:65:4: note: (near initialization for ‘pentry[0].value.raw_data’)
drivers/usb/dwc3/dwc3-pci.c:66:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,req_p1p2p3_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:66:4: note: (near initialization for ‘pentry[1].name’)
drivers/usb/dwc3/dwc3-pci.c:69:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,lfps_filter_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:69:4: note: (near initialization for ‘pentry[1].value.raw_data’)
drivers/usb/dwc3/dwc3-pci.c:70:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,rx_detect_poll_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:70:4: note: (near initialization for ‘pentry[2].name’)
drivers/usb/dwc3/dwc3-pci.c:77:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,disable_scramble_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:77:4: note: (near initialization for ‘pentry[2].value.raw_data’)
drivers/usb/dwc3/dwc3-pci.c:78:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
^
drivers/usb/dwc3/dwc3-pci.c:78:4: note: (near initialization for ‘pentry[3].name’)
drivers/usb/dwc3/dwc3-pci.c:80:4: warning: braces around scalar initializer
{ },
^
drivers/usb/dwc3/dwc3-pci.c:80:4: note: (near initialization for ‘pentry[3].nval’)
drivers/usb/dwc3/dwc3-pci.c:80:4: error: empty scalar initializer
drivers/usb/dwc3/dwc3-pci.c:80:4: note: (near initialization for ‘pentry[3].nval’)
drivers/usb/dwc3/dwc3-pci.c:61:36: warning: missing braces around initializer [-Wmissing-braces]
struct property_entry pentry[] = {
^
drivers/usb/dwc3/dwc3-pci.c:61:36: note: (near initialization for ‘pentry’)
drivers/usb/dwc3/dwc3-pci.c:121:4: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
PROPERTY_ENTRY_BOOL("snps,usb3_lpm_capable"),
^
drivers/usb/dwc3/dwc3-pci.c:121:4: note: (near initialization for ‘pentry[0].name’)
drivers/usb/dwc3/dwc3-pci.c:120:36: warning: missing braces around initializer [-Wmissing-braces]
struct property_entry pentry[] = {
^
drivers/usb/dwc3/dwc3-pci.c:120:36: note: (near initialization for ‘pentry’)
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target 'drivers/usb/dwc3/dwc3-pci.o' failed
make[1]: *** [drivers/usb/dwc3/dwc3-pci.o] Error 1
make[1]: Target '__build' not remade because of errors.
Makefile:1550: recipe for target 'drivers/usb/dwc3/' failed
make: *** [drivers/usb/dwc3/] Error 2
care to respin ?
(this is allmodconfig on x86)
--
balbi
Attachment:
signature.asc
Description: PGP signature
