On Fri, 26 Dec 2008, David Brownell wrote:
> > > Do you just want to provide an update to that patch of
> > > yours (usb-enhance-usage-of-pm_message_t.patch) which
> > > seems to be the proximate cause of the build bugs?
> >
> > We can handle this any way Greg deems best. Since the fix-misspellings
> > patch is already in his tree, the easiest approach is to do nothing and
> > wait for it to be sent in along with everything else during the
> > upcoming merge window.
>
> Did you verify that the fix-misspellings patch suffices for
> the OTG code paths?
It does not; the patch below is needed in addition. (BTW, it's not
entirely clear how to enable CONFIG_USB_OTG if you aren't actually
building any device controller drivers. Editing .config by hand
doesn't work; the build process just turns it back off again.)
Greg, this patch should be combined with the
usb-enhance-usage-of-pm_message_t patch, but it can be added on
separately instead if you prefer.
Alan Stern
-------------------------------------------------------------
From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Carry out the PM-routine interface change in the USB OTG pathway.
This was omitted from the earlier interface-change patch by mistake.
Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
---
Index: usb-2.6/drivers/usb/core/hub.c
===================================================================
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
@@ -1554,7 +1554,7 @@ static int usb_configure_device_otg(stru
* (Includes HNP test device.)
*/
if (udev->bus->b_hnp_enable || udev->bus->is_b_host) {
- err = usb_port_suspend(udev);
+ err = usb_port_suspend(udev, PMSG_SUSPEND);
if (err < 0)
dev_dbg(&udev->dev, "HNP fail, %d\n", err);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
