On 11/11/2015 11:13 PM, Stefan Wahren wrote:
> Am 12.11.2015 um 05:39 schrieb John Youn:
>> On 11/11/2015 3:20 PM, Stefan Wahren wrote:
>>> Hi John,
>>>
>>> Am 11.11.2015 um 00:21 schrieb John Youn:
>>>> On 11/9/2015 12:43 PM, Stefan Wahren wrote:
>>>>> Hi,
>>>>
>>>> The gadget side required it but it looks like the host side
>>>> didn't.
>>>>
>>>> When Marek did the low-level hw refactor, some of the gadget
>>>> stuff was brought up to the common layer, including the returning
>>>> of -EPROBE_DEFER when no phys are defined.
>>>>
>>>> I think this requirement can be removed. At least only enforce it
>>>> for the gadget as before.
>>>>
>>>> Could you see if the following fixes it?
>>>
>>> the patch looks okay, but it didn't get USB working after applying your
>>> patch in combination with my patch.
>>>
>>> devm_phy_get(hsotg->dev, "usb2-phy") failed, but ret has a value of -38.
>>> I don't know where this strange value comes from.
>>
>> Anyone know where the -38 (-ENOSYS) might be coming from for rpi?
>> I couldn't see anything obvious.
>
> I found it. In case IS_ENABLED(CONFIG_GENERIC_PHY) is false
> the function devm_phy_get is replace by the following stub:
>
> static inline struct phy *devm_phy_get(struct device *dev, const char
> *string)
> {
> return ERR_PTR(-ENOSYS);
> }
>
Ah I missed that. Looks like -ENOSYS should be ignored as well. I
see dwc3 does the same. I will update the patch and resend
tomorrow.
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
