Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Petr Štetiar <ynezz@xxxxxxx> writes:
> Bjørn Mork <bjorn@xxxxxxx> [2015-11-03 13:37:56]:
>
>> I guess this means that we need to add an interface count quirk to the
>> qmi_wwan driver as well?  I assume there are devices out there with the
>> same device ID, the same ff/ff/ff interface descriptors, but with
>> QMI/net on interface #0.
>
> Indeed, your guess is correct. Would something like proposed patch bellow get
> accepted?

I can of course noe speak for Greg wrt the bNumInterfaces matching, but
my gut feeling is that this is not useful in general.  There are
hopefully extremely few devices like this, where we have to resort to
that field to be able to identify a function.  There are probably no
other known candidates which could justify this as a USB core feature? 

Based on that, I wonder if it wouldn't be more appropriate to simply do
this as a device specific quirk in the qmi_wwan probe?  At least for the
time being.  We can always make it a generic feature if this ever
becomes a common problem. Which I doubt, because this type of device
will be a problem for any OS/driver.  AFAICS, there is no way you can
use both an "Acer Gobi 2000 Modem device (VP413)" and a "Quectel EC20
LTE Mini PCIe" on the same Windows PC.

Which makes me wonder if the Acer device exists at all. The "VP413"
suggests that we have scraped this from a CodeAurora driver. Which might
have been wrong.  But I guess we have no way to know for sure, so it's a
bit risky just assuming that now.  Yuck, again..




Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux