Re: [PATCH v3 5/6] usb: bcma: add USB 3.0 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/10/15 14:37, Hauke Mehrtens wrote:
> From: Rafał Miłecki <zajec5@xxxxxxxxx>
> 
> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> ---

[snip]

> +
> +	switch (chipinfo->id) {
> +	case BCMA_CHIP_ID_BCM4707:

All the code above cries for being a proper USB PHY driver, is there a
particular reason why it needs to be living in bcma-hcd.c other than
being convenient?

> +		if (chipinfo->rev == 4) {
> +			/* For NS-B0, USB3 PLL Block */
> +			bcma_wait_reg(bus, ccb->mii + 0x000, 0x0100, 0x0000, 1000);
> +			iowrite32(0x587e8000, ccb->mii + 0x004);
> +
> +			/* Clear ana_pllSeqStart */
> +			bcma_wait_reg(bus, ccb->mii + 0x000, 0x0100, 0x0000, 1000);
> +			iowrite32(0x58061000, ccb->mii + 0x004);


---
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux