Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015-07-24 16:30, Johan Hovold wrote:
On Fri, Jul 24, 2015 at 10:59:48AM +0200, Dirk Behme wrote:
On 24.07.2015 10:45, Johan Hovold wrote:
On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote:
On 23.07.2015 19:26, Johan Hovold wrote:

This is probably the right driver, but I'm confused over the DirectIP
bits. Those interfaces are lacking AFAICT and still your comment claims
it's a DirectIP modem (that would also require it to be added not the
network driver).


As we just use this device as ttyUSBx, it seems the "Direct IP modems"
comment might be wrong and a copy & paste error. I'll remove it in v3.

Ok?

Sounds good. And drop the blacklisting too.


Just for better understanding:

We took the existing 0x68AA device

{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
    .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist

as an example for our 0x68AB.

Do we have a lsusb from the 0x68AA to get an idea what's different
between the existing 0x68AA and the new 0x68AB? I.e. why 0x68AA needs
the blacklisting, but 0x68AB not?

Blacklisting the direct-ip interfaces means blacklisting the following
interfaces

	static const u8 direct_ip_non_serial_ifaces[] = { 7, 8, 9, 10, 11, 19, 20 };

as they are supposed to be handled by a network driver instead.

As these are not present in your device, it's not a direct-ip device and
does not need blacklisting.

But note that if the device can be reconfigured for direct ip, without
changing product id, then the blacklisting may be needed, but I'd like
to hear what the modem people thinks about that. AFAIK, switching to
direct ip mode has switched product id in the past.

I'm sure you can find lsusb output for 0x68aa in the archives or through
a search engine.

Johan


The interface layout of 1199:68ab does not look like 1199:68aa does, it has instead more in common with MC879x modules 1199:683c/683d which also are composite devices with 7 interfaces (0..6) and also MDM62xx based as the AR8550. The major difference is from what I can see only the interface attributes 02/02/01 on interfaces 3 and 4 on the AR8550, they are
vendor specific ff/ff/ff on MC879x modules.

So the Sierra driver seems to be the right driver for the AR8550, I only
find it strange that Sierra hasn't added it.
Somehow I would also expect them to tell their customers (which I assume Dirkäs employer is) which driver to use..

/Lars





--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux