Re: [PATCH v2] USB: sierra: add 1199:68AB device ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.07.2015 12:36, Johan Hovold wrote:
On Thu, Jul 23, 2015 at 12:31:55PM +0200, Dirk Behme wrote:
Hi Johan,

On 20.07.2015 11:24, Johan Hovold wrote:
[ +CC: Bjørn and Dan ]

On Mon, Jul 20, 2015 at 08:14:19AM +0200, Dirk Behme wrote:
Add support for the Sierra Wireless AR8550 device with
USB descriptor 0x1199, 0x68AB. For this, lsusb reports:

Thanks for the patch. This modem business is a bit of a mess and it's
not always apparent what driver a device id belongs to.

Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
Device Descriptor:
    bLength                18
    bDescriptorType         1
    bcdUSB               2.00
    bDeviceClass            0 (Defined at Interface level)
    bDeviceSubClass         0
    bDeviceProtocol         0
    bMaxPacketSize0        64
    idVendor           0x1199 Sierra Wireless, Inc.
    idProduct          0x68ab
    bcdDevice            0.06
    iManufacturer           3 Sierra Wireless, Incorporated
    iProduct                2 AR8550
    iSerial                 0
    bNumConfigurations      1
    Configuration Descriptor:
      bLength                 9
      bDescriptorType         2
      wTotalLength          198
      bNumInterfaces          7

[...]

Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
---
Changes in v2: Improve the commit message.

   drivers/usb/serial/sierra.c | 3 +++
   1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
   	{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
   	  .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
   	},
+	{ USB_DEVICE(0x1199, 0x68AB),   /* Sierra Wireless Direct IP modems */
+	  .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+	},

This device has seven interfaces (0..6) so why do you use the direct-ip
interface blacklisting, which only blacklists interfaces >= 7?


Using it the same way like the quite similar ID 0x1199, 0x68AA above
'just works for us'. Not being the experts on this, do you like to
propose anything else you like us to try?


Also do you notice any delays when connecting the device (which could
indicate that sierra is not the right driver)?

As above, do you like us to try anything else?

Could you post a log from when connecting the device with you patch
applied?


Are you looking for something like this?

[  102.948830] usb 1-1: new high-speed USB device number 4 using ci_hdrc
[  103.101172] usb 1-1: New USB device found, idVendor=1199, idProduct=68ab
[ 103.101239] usb 1-1: New USB device strings: Mfr=3, Product=2, SerialNumber=0
[  103.101270] usb 1-1: Product: AR8550
[  103.101297] usb 1-1: Manufacturer: Sierra Wireless, Incorporated
[  103.195766] usbcore: registered new interface driver usbserial
[  103.204471] usbcore: registered new interface driver sierra
[  103.204692] usbserial: USB Serial support registered for Sierra USB modem
[  103.204861] sierra 1-1:1.0: Sierra USB modem converter detected
[  103.218385] usb 1-1: Sierra USB modem converter now attached to ttyUSB0
[  103.220304] sierra 1-1:1.1: Sierra USB modem converter detected
[  103.227186] usb 1-1: Sierra USB modem converter now attached to ttyUSB1
[  103.227721] sierra 1-1:1.2: Sierra USB modem converter detected
[  103.234287] usb 1-1: Sierra USB modem converter now attached to ttyUSB2
[  103.234533] sierra 1-1:1.3: Sierra USB modem converter detected
[  103.236469] usb 1-1: Sierra USB modem converter now attached to ttyUSB3
[  103.236663] sierra 1-1:1.4: Sierra USB modem converter detected
[  103.237712] usb 1-1: Sierra USB modem converter now attached to ttyUSB4
[  103.237873] sierra 1-1:1.5: Sierra USB modem converter detected
[  103.247026] usb 1-1: Sierra USB modem converter now attached to ttyUSB5
[  103.247327] sierra 1-1:1.6: Sierra USB modem converter detected
[  103.251378] usb 1-1: Sierra USB modem converter now attached to ttyUSB6


Best regards

Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux