[ +CC: Bjørn and Dan ]
On Mon, Jul 20, 2015 at 08:14:19AM +0200, Dirk Behme wrote:
> Add support for the Sierra Wireless AR8550 device with
> USB descriptor 0x1199, 0x68AB. For this, lsusb reports:
Thanks for the patch. This modem business is a bit of a mess and it's
not always apparent what driver a device id belongs to.
> Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
> Device Descriptor:
> bLength 18
> bDescriptorType 1
> bcdUSB 2.00
> bDeviceClass 0 (Defined at Interface level)
> bDeviceSubClass 0
> bDeviceProtocol 0
> bMaxPacketSize0 64
> idVendor 0x1199 Sierra Wireless, Inc.
> idProduct 0x68ab
> bcdDevice 0.06
> iManufacturer 3 Sierra Wireless, Incorporated
> iProduct 2 AR8550
> iSerial 0
> bNumConfigurations 1
> Configuration Descriptor:
> bLength 9
> bDescriptorType 2
> wTotalLength 198
> bNumInterfaces 7
[...]
> Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> ---
> Changes in v2: Improve the commit message.
>
> drivers/usb/serial/sierra.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> index 46179a0..4122e4f 100644
> --- a/drivers/usb/serial/sierra.c
> +++ b/drivers/usb/serial/sierra.c
> @@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
> .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
> },
> + { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
> + .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
> + },
This device has seven interfaces (0..6) so why do you use the direct-ip
interface blacklisting, which only blacklists interfaces >= 7?
Also do you notice any delays when connecting the device (which could
indicate that sierra is not the right driver)? A log snipped from when
plugging the device in should reveal this.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
