Re: [PATCH v7 4/4] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-07-15 at 11:42 +0200, Johan Hovold wrote:
> On Sun, Jun 28, 2015 at 01:28:21PM -0500, Peter E. Berger wrote:
> > From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
> > 
> > When using newer Edgeport devices such as the EP/416, idle ports are
> > automatically bounced (disconnected and then reconnected) approximately
> > every 60 seconds.  This breaks programs (e.g: minicom) where idle periods
> > are common, normal and expected.
> > 
> > I confirmed with the manufacturer (Digi International) that some Edgeports
> > now ship from the factory with firmware that expects periodic "heartbeat"
> > queries from the driver to keep idle ports alive.  This patch implements
> > heartbeat support using the mechanism Digi suggested (periodically
> > requesting an I2C descriptor address) that appears effective on Edgeports
> > running the newer firmware (that require it) and benign on Edgeport
> > devices running older firmware.  Since we know that Edgeport firmware
> > version 4.80 (the version distributed in /lib/firmware/down3.bin and used
> > for Edgeports that are either running still older versions or have no
> > onboard non-volatile firmware image) does not require heartbeat support,
> > this patch schedules heartbeats only on devices running firmware versions
> > newer than 4.80.
> 
> Looks good now.
> 
> I did a quick test here with an Edgeport/1 and firmware version 4.80 and
> 5.32 (from digi's ftp) and do not see any disconnects with either
> version even without this patch.
> 
> Is that expected? Is only EP/416 affected or are you seeing these
> disconnects with even newer firmware than 5.32?

I checked again with my Digi contact who looked into this and reported
that the EP/416 models are currently the only ones that require
keepalive heartbeat support and only when running newer firmware such as
5.32 and 5.38.  So I changed the code to only schedule heartbeats for
EP/416 models (there are two flavors with separate product IDs) and
changed the patch subject and text to reflect this change.

Thanks.
     --Peter

> 
> Thanks,
> Johan


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux