Re: [PATCH v7 0/4] Fix idle port disconnects and firmware downloading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2015-06-28 at 13:28 -0500, Peter E. Berger wrote:
> From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
> 
> I found that when using newer Edgeport devices such as the EP/416,
> idle ports are regularly bounced (disconnected and then reconnected).
> I discussed this with the manufacturer (Digi International) and learned
> that some newer Edgeport devices now ship from the factory running
> firmware that requires periodic heartbeat messages from the driver,
> so I enclose a proposed patch to implement their suggested mechanism
> (which works both with old and new Edgeport devices).
> 
> While developing my heartbeat patch, I discovered that the firmware
> download code was not working properly, so I also include three proposed
> patches to fix this.
> 
> I welcome any comments or suggestions.
> 
> Thanks.
>      --Peter
> 
> Changes since v6 [1]
> Addressing Johan's review comments.  Thanks Johan!
> 
>  - Added a fourth patch to include sanity checks on the firmware image

Hi Johan:

Thanks for all your help getting this patchset to this point.  Could you
advise me about whether I should just wait for a v7 review, or if
there's something that I may have missed or otherwise should be doing to
move the patchset forward?

Thanks.
     --Peter


> 
> [1]: v6: http://marc.info/?l=linux-usb&m=143462784601859&w=2
> 
> Peter E. Berger (4):
>   USB: io_ti: Increase insufficient timeout for firmware downloads
>   USB: io_ti: Move request_firmware() calls out of download_fw()
>   USB: io_ti: Add firmware image sanity checks
>   USB: io_ti: Add heartbeat to keep idle Edgeport ports from
>     disconnecting
> 
>  drivers/usb/serial/io_ti.c | 267 ++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 201 insertions(+), 66 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux