Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 23, 2015 at 02:56:23PM -0700, Doug Anderson wrote:
> John and Felipe,
> 
> On Tue, Jun 23, 2015 at 10:56 AM, John Youn <John.Youn@xxxxxxxxxxxx> wrote:
> > On 6/22/2015 4:00 PM, Doug Anderson wrote:
> >> Hi,
> >>
> >> On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf <yousaf.kaukab@xxxxxxxxx> wrote:
> >>>>>>>>> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> >>>>>>>>>
> >>>>>>>>> ---------- 8< ------------------
> >>>>>>>>> [   19.799200] BUG: sleeping function called from invalid context at
> >>>>>>>> mm/slab.c:2863
> >>>>>>>>
> >>>>>>>> Will I see a patch for fixing this ?
> >>>>>>>
> >>>>>>> I am currently on a business trip and can't look into this for at
> >>>>>>> least a couple of weeks.
> >>>>>>
> >>>>>> John, since this is your driver, could you fix it up ?
> >>>>>>
> >>>>>
> >>>>> Hi Felipe,
> >>>>>
> >>>>> I've been out of the office for the past 2 weeks and am catching up on
> >>>>> stuff now.
> >>>>>
> >>>>> I'll take a look at it later this week if I don't hear anything from
> >>>>> Yousaf.
> >>>
> >>> I have patches to fix this issue (and another one). I will send them out hopefully tomorrow.
> >>
> >> I noticed that (33ad261 usb: dwc2: host: spinlock urb_enqueue) is now
> >> in linuxnext, so I pulled it (and many other) changes into the
> >> chromeos-3.14 kernel for testing.  I still see the problem that Heiko
> >> reported.  Note that aside from the warning, this causes all sorts of
> >> "spinlock recursion" issues and an eventual freeze on my system.
> >>
> >> Until Yousaf's patch has landed it seems as if we should do a revert
> >> of (33ad261 usb: dwc2: host: spinlock urb_enqueue) to avoid regressing
> >> existing systems.
> >>
> >> -Doug
> >>
> >
> > Hi Doug,
> >
> > Hopefully the fixes will go into the next rc.
> >
> >
> > Hi Felipe,
> >
> > If you haven't already, could you queue these patches for the next rc? They fix issues for patches applied for 4.2.
> >
> > http://marc.info/?l=linux-usb&m=143409924626643&w=2
> > http://marc.info/?l=linux-usb&m=143409925026644&w=2
> > http://marc.info/?l=linux-usb&m=143409925026645&w=2
> 
> OK, I tried those changes and they fix my problems too (which is not a
> terrible surprise).  You can add my Tested-by if it helps.
> 
> We need either these fixes or a revert of the patch.  As it stands
> right now ToT linuxnext is pretty broken for me.

Can someone resend patches which need to be applied with proper Acks and
Tested-bys in place ? This would go a long way. Keep in mind I won't
apply patches before -rc1 is tagged though.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux