RE: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@xxxxxx]
> Sent: Monday, June 1, 2015 8:34 PM
> To: John Youn
> Cc: balbi@xxxxxx; Kaukab, Yousaf; Heiko Stuebner; linux-usb@xxxxxxxxxxxxxxx;
> Herrero, Gregory; r.baldyga@xxxxxxxxxxx;
> dinguyen@xxxxxxxxxxxxxxxxxxxxx; zhangfei.gao@xxxxxxxxxx;
> jwerner@xxxxxxxxxxxx; sergei.shtylyov@xxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver
> 
> On Mon, Jun 01, 2015 at 06:16:03PM +0000, John Youn wrote:
> > On 5/26/2015 8:21 AM, Felipe Balbi wrote:
> > > On Tue, May 26, 2015 at 03:18:32PM +0000, Kaukab, Yousaf wrote:
> > >>> -----Original Message-----
> > >>> From: Felipe Balbi [mailto:balbi@xxxxxx]
> > >>> Sent: Tuesday, May 26, 2015 11:12 PM
> > >>> To: Heiko Stuebner
> > >>> Cc: Kaukab, Yousaf; linux-usb@xxxxxxxxxxxxxxx; balbi@xxxxxx;
> > >>> john.youn@xxxxxxxxxxxx; Herrero, Gregory; r.baldyga@xxxxxxxxxxx;
> > >>> dinguyen@xxxxxxxxxxxxxxxxxxxxx; zhangfei.gao@xxxxxxxxxx;
> > >>> jwerner@xxxxxxxxxxxx; sergei.shtylyov@xxxxxxxxxxxxxxxxxx
> > >>> Subject: Re: [PATCH v5 00/22] usb: third series of updates for
> > >>> dwc2 driver
> > >>>
> > >>> On Sun, May 24, 2015 at 12:33:39AM +0200, Heiko Stuebner wrote:
> > >>>> Hi,
> > >>>>
> > >>>> Am Mittwoch, 29. April 2015, 22:08:58 schrieb Mian Yousaf Kaukab:
> > >>>>> Hi,
> > >>>>> This patchset consists of some bug fixes and feature
> > >>>>> enhancements for the dwc2 driver. All the patches are verified
> > >>>>> on dwc2 v3.0a with dedicated fifos. Main focus of testing was with
> dma enabled.
> > >>>>> Although basic testing without dma was also done.
> > >>>>>
> > >>>>> This is based on testing/next branch in Felipe's git.
> > >>>>>
> > >>>>> Thank you,
> > >>>>>
> > >>>>> Best regards,
> > >>>>> Yousaf
> > >>>>>
> > >>>>> History:
> > >>>>> v5:
> > >>>>>  - Fixed comments from Felipe Balbi
> > >>>>> v4:
> > >>>>>  - Fixed comment from Julius Werner
> > >>>>> v3:
> > >>>>>  - Fixed comments from Julius Werner and Sergei Shtylyov
> > >>>>>  - Dropped "usb: dwc2: allow dwc2_pci to be a module even when
> > >>>>> dwc2 is statically linked" due to
> > >>>>> http://marc.info/?l=linux-usb&m=142661773703793&w=2
> > >>>>>  - "usb: dwc2: host: ensure qtb exists before dereferencing it" is added
> > >>>>>    to fix a NULL pointer dereferencing bug
> > >>>>> v2:
> > >>>>>  - Fixed comments from John Youn and Julius Werner
> > >>>>>  - Fixed regression, found by John, when switching to gadget mode
> > >>>>>    after running host mode
> > >>>>>  - Added patch to add core parameter for enabling/disabling
> > >>>>> hibernation
> > >>>>>  - Added patch to build dwc2_pci.ko independent from dwc2.ko
> > >>>>> v1:
> > >>>>>  - Fixed comments from John Youn and Robert Baldyga
> > >>>>>  - Dropped all changes to pci.c due to
> > >>>>>    http://permalink.gmane.org/gmane.linux.usb.general/123411
> > >>>>>  - Added patch to remove unnecessary EXPORT_SYMBOL_GPL calls
> > >>>>
> > >>>> With this series applied I get the warning below about a sleeping
> > >>>> function, that is not present without it. This happens quite
> > >>>> often (on boot, when going to suspend, etc).
> > >>>>
> > >>>> Other than that, usb still works and the dwc2 now also finally
> > >>>> suspends :-D, so on a rk3288
> > >>>>
> > >>>> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> > >>>>
> > >>>> ---------- 8< ------------------
> > >>>> [   19.799200] BUG: sleeping function called from invalid context at
> > >>> mm/slab.c:2863
> > >>>
> > >>> Will I see a patch for fixing this ?
> > >>
> > >> I am currently on a business trip and can't look into this for at
> > >> least a couple of weeks.
> > >
> > > John, since this is your driver, could you fix it up ?
> > >
> >
> > Hi Felipe,
> >
> > I've been out of the office for the past 2 weeks and am catching up on
> > stuff now.
> >
> > I'll take a look at it later this week if I don't hear anything from
> > Yousaf.

I have patches to fix this issue (and another one). I will send them out hopefully tomorrow.

> 
> Cool, thanks a lot :-)
> 
> --
> balbi

BR,
Yousaf
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux