Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am Mittwoch, 29. April 2015, 22:08:58 schrieb Mian Yousaf Kaukab:
> Hi,
> This patchset consists of some bug fixes and feature enhancements for
> the dwc2 driver. All the patches are verified on dwc2 v3.0a with
> dedicated fifos. Main focus of testing was with dma enabled. Although
> basic testing without dma was also done.
> 
> This is based on testing/next branch in Felipe's git.
> 
> Thank you,
> 
> Best regards,
> Yousaf
> 
> History:
> v5:
>  - Fixed comments from Felipe Balbi
> v4:
>  - Fixed comment from Julius Werner
> v3:
>  - Fixed comments from Julius Werner and Sergei Shtylyov
>  - Dropped "usb: dwc2: allow dwc2_pci to be a module even when dwc2 is
> statically linked" due to
> http://marc.info/?l=linux-usb&m=142661773703793&w=2
>  - "usb: dwc2: host: ensure qtb exists before dereferencing it" is added
>    to fix a NULL pointer dereferencing bug
> v2:
>  - Fixed comments from John Youn and Julius Werner
>  - Fixed regression, found by John, when switching to gadget mode
>    after running host mode
>  - Added patch to add core parameter for enabling/disabling hibernation
>  - Added patch to build dwc2_pci.ko independent from dwc2.ko
> v1:
>  - Fixed comments from John Youn and Robert Baldyga
>  - Dropped all changes to pci.c due to
>    http://permalink.gmane.org/gmane.linux.usb.general/123411
>  - Added patch to remove unnecessary EXPORT_SYMBOL_GPL calls

With this series applied I get the warning below about a sleeping
function, that is not present without it. This happens quite often (on boot,
when going to suspend, etc).

Other than that, usb still works and the dwc2 now also
finally suspends :-D, so on a rk3288

Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>

---------- 8< ------------------
[   19.799200] BUG: sleeping function called from invalid context at mm/slab.c:2863
[   19.806601] in_atomic(): 1, irqs_disabled(): 128, pid: 101, name: kworker/0:2
[   19.813728] INFO: lockdep is turned off.
[   19.817649] irq event stamp: 0
[   19.820702] hardirqs last  enabled at (0): [<  (null)>]   (null)
[   19.826720] hardirqs last disabled at (0): [<c00273f4>] copy_process.part.46+0x430/0x1784
[   19.834916] softirqs last  enabled at (0): [<c00273f4>] copy_process.part.46+0x430/0x1784
[   19.843104] softirqs last disabled at (0): [<  (null)>]   (null)
[   19.849126] CPU: 0 PID: 101 Comm: kworker/0:2 Tainted: G        W       4.1.0-rc4+ #1963
[   19.857208] Hardware name: Rockchip (Device Tree)
[   19.861916] Workqueue: events usbnet_deferred_kevent
[   19.866910] [<c00189a0>] (unwind_backtrace) from [<c0013b04>] (show_stack+0x20/0x24)
[   19.874659] [<c0013b04>] (show_stack) from [<c075c154>] (dump_stack+0x8c/0xbc)
[   19.881888] [<c075c154>] (dump_stack) from [<c0053188>] (___might_sleep+0x238/0x284)
[   19.889636] [<c0053188>] (___might_sleep) from [<c0053264>] (__might_sleep+0x90/0xa4)
[   19.897468] [<c0053264>] (__might_sleep) from [<c0154aa8>] (kmem_cache_alloc_trace+0x90/0x3e0)
[   19.906081] [<c0154aa8>] (kmem_cache_alloc_trace) from [<c0442a68>] (_dwc2_hcd_urb_enqueue+0x298/0x464)
[   19.915476] [<c0442a68>] (_dwc2_hcd_urb_enqueue) from [<c042a748>] (usb_hcd_submit_urb+0x7bc/0x8f0)
[   19.924522] [<c042a748>] (usb_hcd_submit_urb) from [<c042c158>] (usb_submit_urb+0x45c/0x4ac)
[   19.932961] [<c042c158>] (usb_submit_urb) from [<c042cc60>] (usb_start_wait_urb+0x54/0x148)
[   19.941314] [<c042cc60>] (usb_start_wait_urb) from [<c042cf44>] (usb_control_msg+0xac/0xe0)
[   19.949668] [<c042cf44>] (usb_control_msg) from [<c041c4d4>] (__usbnet_read_cmd+0xc0/0x104)
[   19.958021] [<c041c4d4>] (__usbnet_read_cmd) from [<c041c63c>] (usbnet_read_cmd+0x64/0x84)
[   19.966294] [<c041c63c>] (usbnet_read_cmd) from [<bf13c790>] (__smsc95xx_read_reg+0x68/0xa4 [smsc95xx])
[   19.975698] [<bf13c790>] (__smsc95xx_read_reg [smsc95xx]) from [<bf13c80c>] (__smsc95xx_phy_wait_not_busy+0x40/0x8c [smsc95xx])
[   19.987180] [<bf13c80c>] (__smsc95xx_phy_wait_not_busy [smsc95xx]) from [<bf13cd04>] (__smsc95xx_mdio_read+0x48/0x110 [smsc95xx])
[   19.998836] [<bf13cd04>] (__smsc95xx_mdio_read [smsc95xx]) from [<bf13cde8>] (smsc95xx_mdio_read+0x1c/0x20 [smsc95xx])
[   20.009539] [<bf13cde8>] (smsc95xx_mdio_read [smsc95xx]) from [<bf13ce34>] (smsc95xx_link_reset+0x48/0x2d4 [smsc95xx])
[   20.020237] [<bf13ce34>] (smsc95xx_link_reset [smsc95xx]) from [<c041f7e4>] (usbnet_deferred_kevent+0x244/0x344)
[   20.030410] [<c041f7e4>] (usbnet_deferred_kevent) from [<c0044d28>] (process_one_work+0x360/0x7f4)
[   20.039367] [<c0044d28>] (process_one_work) from [<c00454a8>] (worker_thread+0x2b0/0x414)
[   20.047546] [<c00454a8>] (worker_thread) from [<c004afe8>] (kthread+0x104/0x11c)
[   20.054947] [<c004afe8>] (kthread) from [<c0010010>] (ret_from_fork+0x14/0x24)
[   20.062456] smsc95xx 2-1.1:1.0 eth0: kevent 4 may have been dropped
[   20.071768] smsc95xx 2-1.1:1.0 eth0: link up, 100Mbps, full-duplex, lpa 0x4DE1
[   20.089180] smsc95xx 2-1.1:1.0 eth0: link up, 100Mbps, full-duplex, lpa 0x4DE1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux