linux-4.1/drivers/usb/serial/io_edgeport.c: 7 * redundant conditions ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello there,

1.

[linux-4.1/drivers/usb/serial/io_edgeport.c:1049]: (style) Redundant condition: edge_serial.is_epic. 'A && (!A || B)' is equivalent to 'A || B'

   if ((!edge_serial->is_epic) ||
        ((edge_serial->is_epic) &&
         (edge_serial->epic_descriptor.Supports.IOSPChase))) {

Maybe

   if ((!edge_serial->is_epic) ||
        edge_serial->epic_descriptor.Supports.IOSPChase) {

2.

[linux-4.1/drivers/usb/serial/io_edgeport.c:1064]: (style) Redundant condition: edge_serial.is_epic. 'A && (!A || B)' is equivalent to 'A || B'

    if ((!edge_serial->is_epic) ||
        ((edge_serial->is_epic) &&
         (edge_serial->epic_descriptor.Supports.IOSPClose))) {

3.

[linux-4.1/drivers/usb/serial/io_edgeport.c:1615]: (style) Redundant condition: edge_serial.is_epic. 'A && (!A || B)' is equivalent to 'A || B'

More of the same at lines 1631, 2468, 2497, 2501

Regards

David Binderman


 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux