On Mon, Jun 22, 2015 at 08:40:51AM +0000, David Binderman wrote:
> Hello there,
>
> 1.
>
> [linux-4.1/drivers/usb/serial/io_edgeport.c:1049]: (style) Redundant condition: edge_serial.is_epic. 'A && (!A || B)' is equivalent to 'A || B'
>
> if ((!edge_serial->is_epic) ||
> ((edge_serial->is_epic) &&
> (edge_serial->epic_descriptor.Supports.IOSPChase))) {
>
> Maybe
>
> if ((!edge_serial->is_epic) ||
> edge_serial->epic_descriptor.Supports.IOSPChase) {
Yes, that is a redundant test.
Care to fix these instances and submit a proper patch that we can apply?
You can drop the parentheses around the negation as well.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
