On Thu, Jun 18, 2015 at 03:18:24PM +0300, Roger Quadros wrote:
> On Thu, 18 Jun 2015 15:55:28 +0800
> Li Jun <b47624@xxxxxxxxxxxxx> wrote:
>
> > On Thu, Jun 18, 2015 at 10:36:50AM +0300, Roger Quadros wrote:
> > > Lin,
> > >
> > > You can use --in-reply-to "message id of v5 of this path" so that it appears together
> > > with the other patches in peoples mailboxes.
> > >
> > okay, I will try that next time, thanks.
> >
> > Li Jun
> > > On Thu, 18 Jun 2015 09:18:22 +0800
> > > Li Jun <jun.li@xxxxxxxxxxxxx> wrote:
> > >
> > >
> > Then that's not so simple, every number should be checked,
> > if ((otg_caps->otg_rev % 10) > 9) ||
> > ((otg_caps->otg_rev >> 4) % 10) > 9) ||
> > ((otg_caps->otg_rev >> 8) % 10) > 9) ||
> > ((otg_caps->otg_rev >> 12) % 10) > 9))
> > return error;
> > We really need this kind of format check? seems no this check
> > for bcdUSB.
>
> How about checking for released spec versions instead?
>
> switch (otg_rev) {
> case 0x0100:
> case 0x0110:
> case 0x0200:
> case 0x0300:
> break;
> default:
> dev_err(dev, "unsupported otg-rev: 0x%x\n", otg_rev);
> return error;
> }
>
Currently only 1.x and 2.0 can make sense, but this could be done.
> cheers,
> -roger
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
