On 17.06.2015 18:19, Rafał Miłecki wrote:
> On 17 June 2015 at 17:11, Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> wrote:
>> On 16.06.2015 23:01, Rafał Miłecki wrote:
>>> On 16 June 2015 at 21:56, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>>>> On Tue, Jun 16, 2015 at 09:18:05PM +0200, Rafał Miłecki wrote:
>>>>> Right now xhci-plat-hcd can be built when using one of platform specific
>>>>> drivers only (mvebu/rcar). There shouldn't be such limitation as some
>>>>> platforms may not require any quirks and may want to just use a generic
>>>>> driver ("generic-xhci" / "xhci-hcd").
>>>>
>>>> Don't you still need some kind of xhci platform driver? On its own,
>>>> xhci-hcd doesn't provide what you need.
>>>
>>> First, I can just "generic-xhci" if the controller doesn't need any
>>> extra setup. See even the example in
>>> Documentation/devicetree/bindings/usb/usb-xhci.txt, there is that:
>>> compatible = "generic-xhci";
>>> example entry for DT.
>>>
>>> And about "xhci-hcd": if there appears (one day) some platform driver
>>> (e.g. non-DT) registering "xhci-hcd" platform device, it'll most
>>> likely handle initialization on its own, before calling the
>>> platform_device_add.
>>
>> True that there is no way to just select the xhci platform driver if all you
>> need is a driver for a "generic-xhci" platform device with only interrupt and mem
>> resources set in the platform device.
>>
>> Is this fixing some real life issue?
>>
>> I don't have strong opinions about this, for me adding this option is fine, or
>> then wait until it's really needed by someone.
>
> I am/was trying to use "generic-xhci" for Broadcom's devices,
> unfortunately I'm still experiencing some stability problems. Not sure
> if there are related to the controller initialization or some more
> low-level stuff.
>
> Anyway, since "generic-xhci" support is there and not all dts files
> are part of kernel, it would be nice if you could accept this patch.
> Please note that there are many dts files living out of kernel source.
> Also some bootloaders support DT natively (it's not dtb appended to
> the kernel binary), so there may be ppl interested in using
> "generic-xhci" even if there isn't any in-kernel dts using that.
>
I'll add to my queue and send it forward to Greg once 4.2-rc1 is out.
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
