Re: [PATCH] usb: xhci: make USB_XHCI_PLATFORM selectable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.06.2015 23:01, Rafał Miłecki wrote:
> On 16 June 2015 at 21:56, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> On Tue, Jun 16, 2015 at 09:18:05PM +0200, Rafał Miłecki wrote:
>>> Right now xhci-plat-hcd can be built when using one of platform specific
>>> drivers only (mvebu/rcar). There shouldn't be such limitation as some
>>> platforms may not require any quirks and may want to just use a generic
>>> driver ("generic-xhci" / "xhci-hcd").
>>
>> Don't you still need some kind of xhci platform driver?  On its own,
>> xhci-hcd doesn't provide what you need.
> 
> First, I can just "generic-xhci" if the controller doesn't need any
> extra setup. See even the example in
> Documentation/devicetree/bindings/usb/usb-xhci.txt, there is that:
> compatible = "generic-xhci";
> example entry for DT.
> 
> And about "xhci-hcd": if there appears (one day) some platform driver
> (e.g. non-DT) registering "xhci-hcd" platform device, it'll most
> likely handle initialization on its own, before calling the
> platform_device_add.

True that there is no way to just select the xhci platform driver if all you
need is a driver for a "generic-xhci" platform device with only interrupt and mem
resources set in the platform device.

Is this fixing some real life issue? 

I don't have strong opinions about this, for me adding this option is fine, or
then wait until it's really needed by someone.

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux