On Wed, 17 Jun 2015, Stefan Koch wrote:
> > > --- a/include/linux/usb.h
> > > +++ b/include/linux/usb.h
> > > @@ -171,6 +171,7 @@ struct usb_interface {
> > > int minor; /* minor number this interface is
> > > * bound to */
> > > enum usb_interface_condition condition; /* state of binding */
> > > + unsigned authorized:1; /* used for interface authorization */
> >
> > You might want to copy the alignment of the other comments. For
> > example, see the comment for "minor" above.
> >
> > > unsigned sysfs_files_created:1; /* the sysfs attributes exist */
> > > unsigned ep_devs_created:1; /* endpoint "devices" exist */
> > > unsigned unregistering:1; /* unregistration is in progress */
> >
> > Alan Stern
> >
> Should I move this attribute before "minor" or before "dev"? Should I
> use :1 or not. I could use instead a bool.
Definitely put this flag adjacent to the other single-bit flags.
Definitely use :1. Whether to make it bool or unsigned is up to you --
for a single-bit value there is no difference.
Also, you should lock intf->dev when changing intf->authorized.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
