Re: [PATCH v3 1/6] usb: interface authorization: Declare authorized attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, den 17.06.2015, 11:09 -0400 schrieb Alan Stern:
> On Wed, 17 Jun 2015, Stefan Koch wrote:
> 
> > The attribute authorized shows the authorization state for an interface.
> > 
> > Signed-off-by: Stefan Koch <skoch@xxxxxxx>
> > ---
> >  include/linux/usb.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/usb.h b/include/linux/usb.h
> > index 447fe29..24983dc 100644
> > --- a/include/linux/usb.h
> > +++ b/include/linux/usb.h
> > @@ -171,6 +171,7 @@ struct usb_interface {
> >  	int minor;			/* minor number this interface is
> >  					 * bound to */
> >  	enum usb_interface_condition condition;		/* state of binding */
> > +	unsigned authorized:1; /* used for interface authorization */
> 
> You might want to copy the alignment of the other comments.  For 
> example, see the comment for "minor" above.
> 
> >  	unsigned sysfs_files_created:1;	/* the sysfs attributes exist */
> >  	unsigned ep_devs_created:1;	/* endpoint "devices" exist */
> >  	unsigned unregistering:1;	/* unregistration is in progress */
> 
> Alan Stern
> 
Should I move this attribute before "minor" or before "dev"? Should I
use :1 or not. I could use instead a bool.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux