RE: [PATCH v2 01/11] usbip: exporting devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Valentina,

> * I noticed in some places you've used labels such as err0 and err1.
> Please replace them with something more relevant to their 
> functionality,
> such as what you're cleaning up after. There are examples of this 
> both in
> USB/IP code and throughout the kernel.

I will fix all in v3.

> * when calling open_hc_device(), you're using magic constants - 0 and 
> 1.
> Define them as constants with meaningful names.

I will fix in v3.

Thanks,

n.iwata
//
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux