Re: [PATCH v2 01/11] usbip: exporting devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I looked around your patch and tested it and looks good.
However, I do have 2 nit-picks:

* I noticed in some places you've used labels such as err0 and err1.
Please replace them with something more relevant to their
functionality, such as what you're cleaning up after. There are
examples of this both in USB/IP code and throughout the kernel.
* when calling open_hc_device(), you're using magic constants - 0 and
1. Define them as constants with meaningful names.

Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux