Hi Bjørn > This cannot possibly be necessary. Pointing to the toplevel "COPYING" > file should be more than enough, if anything at all. > > And BTW, the same goes for the tools/usb/usbip/COPYING that seems to > have snuck in somehow. I also wonder a bit about the AUTHORS file both > places. We have git and MAINTAINERS for such things, don't we? I will remove from v3. > > --- /dev/null > > +++ b/tools/usb/usbip/websocket/configure.ac > > @@ -0,0 +1,61 @@ > > +dnl Process this file with autoconf to produce a configure script. > > + > > +AC_PREREQ(2.59) > > +AC_INIT([usbip-utils], [1.1.1], [linux-usb@xxxxxxxxxxxxxxx]) > > +AC_DEFINE([USBIP_VERSION], [0x00000111], [binary-coded decimal version > number]) > > This should either use the upper level definitions or have its own > namespace. Defining the same symbols at different levels is a recipe > for confusion. In fact, you are already out of sync with the > definitions in tools/usb/usbip/configure.ac Sorry for my carelessness. I will use own AC_INIT() in v3 and remove AC_DEFINE([USBIP_VERSION]) from v3. > > Implementation of this patch depends on Poco C++ > > (http://pocoproject.org/). > > Really? Is that OK? > > Yuck. Any reason this cannot be written in C? I couldn't find good C library which supports both server and client. I intended other implementation may be stored under 'websocket' directory next to 'poco'. Thank you for your comments, n.iwata // ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
