Re: [PATCH v2] usb: phy: generic: Do not fail when 'reset-gpios' is not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 23, 2015 at 2:12 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:

> Ok, I managed to test this on a imx51_babbage that uses reset_gpios.
> Without this patch USB is broken due to e9f2cefb0cdc2ae, but if I
> apply my patch I get a hang:
>
> [    1.392824] ci_hdrc ci_hdrc.1: doesn't support gadget
> [    1.397975] ci_hdrc ci_hdrc.1: EHCI Host Controller
> [    1.403205] ci_hdrc ci_hdrc.1: new USB bus registered, assigned bus number 1
> [    1.422335] ci_hdrc ci_hdrc.1: USB 2.0 started, EHCI 1.00
> [    1.432962] hub 1-0:1.0: USB hub found
> [    1.437119] hub 1-0:1.0: 1 port detected
>
> Will need to debug more.

The problem here is that:

nop->gpiod_reset = devm_gpiod_get(dev, "reset-gpios");

Always return -2.

On imx51-babbage.dts we pass 'reset-gpios' and it used to retrieve it
fine prior to e9f2cefb0cdc2ae ("usb: phy: generic: migrate to
gpio_desc") by using of_get_named_gpio_flags().

Any ideas as to why devm_gpiod_get() always fail now?

I am running linux-next 20150123.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux