On Fri, Jan 23, 2015 at 1:45 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> Commit e9f2cefb0cdc2ae ("usb: phy: generic: migrate to gpio_desc") broke USB on
> imx53-qsb board:
>
> [ 0.115456] usb_phy_generic 50000000.aips:usbphy@0: Error requesting RESET GPIO
> [ 0.115554] usb_phy_generic: probe of 50000000.aips:usbphy@0 failed with error -2
> [ 0.115701] usb_phy_generic 50000000.aips:usbphy@1: Error requesting RESET GPIO
> [ 0.115761] usb_phy_generic: probe of 50000000.aips:usbphy@1 failed with error -2
>
> Driver should still probe even when 'reset-gpios' property is not passed.
>
> Fix the error handling for devm_gpiod_get() and move the
> "Error requesting RESET GPIO" message right after devm_gpio_request_one().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> I haven't tested the case when 'reset-gpios' is present yet.
Ok, I managed to test this on a imx51_babbage that uses reset_gpios.
Without this patch USB is broken due to e9f2cefb0cdc2ae, but if I
apply my patch I get a hang:
[ 1.392824] ci_hdrc ci_hdrc.1: doesn't support gadget
[ 1.397975] ci_hdrc ci_hdrc.1: EHCI Host Controller
[ 1.403205] ci_hdrc ci_hdrc.1: new USB bus registered, assigned bus number 1
[ 1.422335] ci_hdrc ci_hdrc.1: USB 2.0 started, EHCI 1.00
[ 1.432962] hub 1-0:1.0: USB hub found
[ 1.437119] hub 1-0:1.0: 1 port detected
Will need to debug more.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
