Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, January 23, 2015 01:40:46 PM Pawel Moll wrote:
> On Thu, 2015-01-22 at 21:11 +0000, Rafael J. Wysocki wrote:
> > > I'll work on it when I have some spare time.  Of course, it would be 
> > > better if somebody could add the proper wakeup-detect code to the 
> > > isp1760-hcd driver...
> > 
> > Yes, it would.
> 
> Whether it's a hack or no - I don't know, but it makes my board detect
> USB devices again with v3.19-rc5, without any extra kernel parameters:
> 
> 8<---------------
> diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
> index 395649f..92a8297 100644
> --- a/drivers/usb/host/isp1760-hcd.c
> +++ b/drivers/usb/host/isp1760-hcd.c
> @@ -2250,7 +2250,6 @@ struct usb_hcd *isp1760_register(phys_addr_t res_start, resource_size_t res_len,
>  	ret = usb_add_hcd(hcd, irq, irqflags);
>  	if (ret)
>  		goto err_unmap;
> -	device_wakeup_enable(hcd->self.controller);
>  
>  	return hcd;
> 8<---------------

Makes sense to me.  It is not useful to enable features that are not working ...

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux