Re: [PATCHv2 3/4] usb: gadget: uvc: use explicit type instead of void *

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 19.01.2015 o 22:30, Laurent Pinchart pisze:
Hi Andrzej,

On Monday 19 January 2015 23:27:28 Laurent Pinchart wrote:
On Monday 19 January 2015 13:52:57 Andrzej Pietrasiewicz wrote:
The first parameter of __uvcg_iter_strm_cls() is always used in
the context of struct uvcg_streaming_header, so change the
function prototype accordingly.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

I spoke too fast. Shouldn't the first argument of the callback function be a
struct uvcg_streaming_header * as well ?


Both __uvcg_count_strm() and __uvcg_fill_strm() use their 1st parameter
in different contexts, depending whether they are called at the
streaming header, format or frame level. That is why originally
the 1st parameter of __uvcg_iter_strm_cls() was a void * - to emphasize
the fact that what is propagated to the callbacks as the 1st parameter
is not always the same type of thing.

AP
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux