Hi Andrzej, On Tuesday 20 January 2015 08:56:47 Andrzej Pietrasiewicz wrote: > W dniu 19.01.2015 o 22:30, Laurent Pinchart pisze: > > On Monday 19 January 2015 23:27:28 Laurent Pinchart wrote: > >> On Monday 19 January 2015 13:52:57 Andrzej Pietrasiewicz wrote: > >>> The first parameter of __uvcg_iter_strm_cls() is always used in > >>> the context of struct uvcg_streaming_header, so change the > >>> function prototype accordingly. > >>> > >>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> > >> > >> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > I spoke too fast. Shouldn't the first argument of the callback function be > > a struct uvcg_streaming_header * as well ? > > Both __uvcg_count_strm() and __uvcg_fill_strm() use their 1st parameter > in different contexts, depending whether they are called at the > streaming header, format or frame level. That is why originally > the 1st parameter of __uvcg_iter_strm_cls() was a void * - to emphasize > the fact that what is propagated to the callbacks as the 1st parameter > is not always the same type of thing. Right. Let's keep it as-is then. For the whole series, Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
