Re: [PATCHv2 3/4] usb: gadget: uvc: use explicit type instead of void *

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

Thank you for the patch.

On Monday 19 January 2015 13:52:57 Andrzej Pietrasiewicz wrote:
> The first parameter of __uvcg_iter_strm_cls() is always used in
> the context of struct uvcg_streaming_header, so change the
> function prototype accordingly.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/usb/gadget/function/uvc_configfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/uvc_configfs.c
> b/drivers/usb/gadget/function/uvc_configfs.c index 49f25e8..51d8e9e 100644
> --- a/drivers/usb/gadget/function/uvc_configfs.c
> +++ b/drivers/usb/gadget/function/uvc_configfs.c
> @@ -1918,10 +1918,10 @@ enum uvcg_strm_type {
>  	UVCG_FRAME
>  };
> 
> -static int __uvcg_iter_strm_cls(void *priv1, void *priv2, void *priv3,
> +static int __uvcg_iter_strm_cls(struct uvcg_streaming_header *h,
> +	void *priv2, void *priv3,
>  	int (*fun)(void *, void *, void *, int, enum uvcg_strm_type type))
>  {
> -	struct uvcg_streaming_header *h = priv1;
>  	struct uvcg_format_ptr *f;
>  	struct config_group *grp;
>  	struct config_item *item;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux