On Tue, Jan 13, 2015 at 05:41:45PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > There is old, unused code that is #defined out by the > use of NOTMOS7840 - this is not defined anywhere. If > NOTMOS7840 is defined then the code will break on null > pointer dereferences on mos7840_port. So the code is > currently unused, and broken anyway, so why not just > remove it. Makes sense. But why not remove the likewise broken code conditionally compiled on NOTMCS7840 as well? Care to resend and include that as well? Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html