Kevin Zhu <Mingying.Zhu@xxxxxxxxxxxxxx> writes: > Regarding the location of NDP, it should be easy to fix. It can be added > to the end of the NTB only after it's ready to send. Yes, but this will require a bit of redesign. Note that this code is shared with cdc_mbim, which might have to add multiple NDPs for multiplexed sessions. In theory up to 512 different, but that is so unlinkely that we can ignore it. We could set a fixed limit significantly lower than that if necessary. I'd really like to refactor this code to simply queue the skbs, creating the linear NTB only when the queue is flushed. Then we'll have all the info we need and can order the contents any way we want without adding unnecessary padding. > Regarding the > concern to other devices, as there's a particular driver for Huawei > devices in kernel, which is huawei_cdc_ncm, maybe we can just fix the TX > function there to avoid breaking other devices. Sure. That is definitely an alternative if we don't want to touch the generic driver. But making the generic driver flexible enough to accommodate any device would be preferable. I do hope we can do that. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
