On 10/27/2014 02:31 PM, Sergei Shtylyov wrote:
Hello.
On 10/26/2014 9:01 PM, Kyösti Mälkki wrote:
There are applications where it is desirable to not hangup ttyGS* when
USB disconnect is detected. USB host side of communication may
power-cycle periodically or there may be the actual need to physically
disconnect and reconnect USB cable temporarily.
USB disconnects on serial gadget are comparable to loss of Carrier Detect
of conventional UARTs. With the change, if ttyGS* has termios CLOCAL flag
set, disconnect on USB does not hangup the TTY.
Signed-off-by: Kyösti Mälkki <kyosti.malkki@xxxxxxxxx>
---
drivers/usb/gadget/function/u_serial.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_serial.c
b/drivers/usb/gadget/function/u_serial.c
index 491082a..e68ffd7 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -1254,8 +1254,13 @@ void gserial_disconnect(struct gserial *gser)
gser->ioport = NULL;
if (port->port.count > 0 || port->openclose) {
wake_up_interruptible(&port->drain_wait);
- if (port->port.tty)
- tty_hangup(port->port.tty);
+ struct tty_struct *tty = port->port.tty;
Don't declare variables amidst the code. And please add empty line
after declaration.
Sloppy rebase there from my part :/
I'll update once there is advice on the CLOCAL matter itself.
+ if (tty) {
+ if (tty->termios.c_cflag & CLOCAL)
+ stop_tty(tty);
+ else
+ tty_hangup(tty);
+ }
}
WBR, Sergei
Thanks,
KM
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
