Re: usb_stor_control_msg() timeout argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Oct 2014, Mark Knibbs wrote:

> Ah, thanks. Given that, it seems my recent patch
> "[PATCH] storage: Replace magic number with define in usb_stor_euscsi_init()"
> which replaced 5000 with USB_CTRL_SET_TIMEOUT wasn't correct, though that
> patch wouldn't change the compiled code.
> 
> It looks like the 5000 timeout in usb_stor_euscsi_init() should be replaced
> by 5*HZ then?

Yes, it does look wrong.  There may be other places that also call the 
function with a timeout value in ms rather than jiffies...

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux