Re: xHCI regression for VIA USB 3.0 controller in handle_cmd_completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> The SLOT ID for reset device command completion TRB's isn't very well documented.
>> If VIA chose to set it to zero we should use what works best, e.g. dig out the
>> SLOT ID from the queued command TRB. This has been working previously.
> 
> For Reset Device in Section 4.6.1, it says:
> "Insert a Command Completion Event on the Event Ring of Interrupter 0
> and initialize the following fields:
> ...
>  Clear all other fields of the event TRB to ‘0’."
> 
> Can "all other fields" be interpreted to include Slot ID?
> 

Thats right, so it does. The VIA controller behaving like it should.

>> I'd like to use Saran's patch partly, I'd like to keep Xenia's WARN and compare
>> SLOT ID's in the cases specs clearly specify event SLOT ID. In the Reset Device
>> case use the command TRB SLOT ID.
>>
>> I can do this myself, but if you, Saran, feel you want to send a patch for it
>> please let me know
> 
> Thanks for asking, but since the patch is trivial, it'll be
> easier/faster if you write/backport it.
> 

Sure, will do it.

Thanks
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux